fix: use DefaultObjectPoolProvider to get a DisposableObjectPool inst…#427
Merged
catcherwong merged 1 commit intodotnetcore:devfrom Nov 24, 2022
Merged
fix: use DefaultObjectPoolProvider to get a DisposableObjectPool inst…#427catcherwong merged 1 commit intodotnetcore:devfrom
catcherwong merged 1 commit intodotnetcore:devfrom
Conversation
…ead of a DefaultObjectPool Default object pool does not dispose non-retained object, leading to IModel leakage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default object pool does not dispose non-retained objects, leading to IModel leakage. Using the DefaultObjectPoolProvider will result in getting a DisposableObjectPool that does dispose non-retained objects.